feat: Support proxy option
#614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning: This pull request is touching the following templated files:
|
danielbankhead
commented
Apr 5, 2024
Comment on lines
+339
to
+342
| opts.agent = new HttpsProxyAgent(proxy, { | ||
| cert: opts.cert, | ||
| key: opts.key, | ||
| }); |
There was a problem hiding this comment.
Looking at the following link I do not believe mTLS was working for proxied requests previously:
This was due to HttpsProxyAgent being any at the time
There was a problem hiding this comment.
Woah, if I'm reading this right how did it work at all? Looks like the first parameter should have been Uri | URL, not an object. Nice catch.
There was a problem hiding this comment.
Yep! Never worked at all 😔
danielbankhead
commented
Apr 5, 2024
Comment on lines
+467
to
+485
|
|
||
| /** | ||
| * A cache for the lazily-loaded proxy agent. | ||
| * | ||
| * Should use {@link Gaxios[#getProxyAgent]} to retrieve. | ||
| */ | ||
| // using `import` to dynamically import the types here | ||
| static #proxyAgent?: typeof import('https-proxy-agent').HttpsProxyAgent; | ||
|
|
||
| /** | ||
| * Imports, caches, and returns a proxy agent - if not already imported | ||
| * | ||
| * @returns A proxy agent | ||
| */ | ||
| static async #getProxyAgent() { | ||
| this.#proxyAgent ||= (await import('https-proxy-agent')).HttpsProxyAgent; | ||
|
|
||
| return this.#proxyAgent; | ||
| } |
There was a problem hiding this comment.
This may have the convenient side-effect of preventing esbuild from automatically pulling this in!
See out.js via:
npx esbuild ./build/src/index.js --platform=node --bundle --outfile=out.jsRelated:
|
Working on some tests. |
product-auto-label
bot
added
size: l
ddelgrosso1
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #520
🦕